[ https://issues.apache.org/jira/browse/PIG-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1575: ---------------------------- Attachment: jira-1575-5.patch Patch looks good. Attach the final patch. test patch result: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. All tests pass. Patch committed to both trunk and 0.8 branch. > Complete the migration of optimization rule PushUpFilter including missing > test cases > ------------------------------------------------------------------------------------- > > Key: PIG-1575 > URL: https://issues.apache.org/jira/browse/PIG-1575 > Project: Pig > Issue Type: Bug > Reporter: Xuefu Zhang > Assignee: Xuefu Zhang > Fix For: 0.8.0 > > Attachments: jira-1575-1.patch, jira-1575-2.patch, jira-1575-3.patch, > jira-1575-4.patch, jira-1575-5.patch > > > The Optimization rule under the new logical plan, PushUpFilter, only does a > subset of optimization scenarios compared to the same rule under the old > logical plan. For instance, it only considers filter after join, but the old > optimization also considers other operators such as CoGroup, Union, Cross, > etc. The migration of the rule should be complete. > Also, the test cases created for testing the old PushUpFilter wasn't migrated > to the new logical plan code base. It should be also migrated. (A few has > been migrated in JIRA-1574.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.