[
https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605022#action_12605022
]
Santhosh Srinivasan commented on PIG-162:
-----------------------------------------
Comments on newChanges.patch:
- test/org/apache/pig/test/TestCountExprOp.java
i. the entire test is in the method setUp. Can the relevant portions be
moved to testCount() ?
- src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt
i. The keyword countexpr should be count
ii. In the method CountExpr, the function arguments to count should be
like that of FuncEvalSpec
{code}
"(" args=EvalArgs(over,specs,lp,input) ")"
{code}
- src/org/apache/pig/impl/logicalLayer/LogToPhyTranslationVisitor.java
i. public void visit(LOSplit split) is completely commented in java docs.
ii. public void visit(LOAnd op) and public void visit(LOOr op) are marked
as deleted.
iii. COUNT.java is an algebraic function wheras POCount is not. Does this
have any impact?
> Rework mapreduce submission and monitoring
> ------------------------------------------
>
> Key: PIG-162
> URL: https://issues.apache.org/jira/browse/PIG-162
> Project: Pig
> Issue Type: Sub-task
> Environment: This bug tracks works to rework the submission and
> monitoring interface to map reduce as described in
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: changes.patch, changes1.patch, incr7.patch, incr8.patch,
> mapreduceJumbo.patch, mapreduceJumboWithComInc.patch, modJumbo.patch,
> newChanges.patch, split.png, TEST-org.apache.pig.test.TestMapReduce.txt,
> TEST-org.apache.pig.test.TestMRCompiler.txt,
> TEST-org.apache.pig.test.TestMRCompiler.txt,
> TEST-org.apache.pig.test.TestUnion.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
