[
https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616723#action_12616723
]
Santhosh Srinivasan commented on PIG-269:
-----------------------------------------
Comments on Pig-154 merge:
Major:
File: src/org/apache/pig/PigServer.java
I am not sure if we can use op = lp.getSingleLeafPlanOutputOp(); for split. It
will probably result in an exception
{code}
+ LogicalOperator op = null;
try {
lp = (new LogicalPlanBuilder(pigContext).parse(scope, query,
aliases, opTable, aliasOp));
+ op = lp.getSingleLeafPlanOutputOp();
} catch (ParseException e) {
throw (IOException) new IOException(e.getMessage()).initCause(e);
}
{code}
Minor:
File: test/org/apache/pig/test/TestLogicalPlanBuilder.java
PigContext has been moved to the global scope. Testers have to be careful about
define statements that persist between queries.
{code}
+ PigContext pigContext = new PigContext(ExecType.LOCAL, new Properties());
{code}
> Merge changes from trunk to "types" branch
> ------------------------------------------
>
> Key: PIG-269
> URL: https://issues.apache.org/jira/browse/PIG-269
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: types_branch
> Reporter: Pradeep Kamath
> Assignee: Alan Gates
> Fix For: types_branch
>
> Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch,
> merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch,
> PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch,
> PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created.
> This jira issue is to track merging the changes from trunk to "types" branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
