On 21 May 2012 11:08, Pauli Nieminen <[email protected]> wrote:
> Preparing to pass more parameters depending of build configuration to > create GLES dispatch tables too. > Sorry for taking so long to get around to reviewing these, Pauli. I'm worried that your plans for piglit may be at cross purposes with what Chad and I were planning. We have been hoping to eliminate the separate builds for GLES, so that piglit builds just a single set of binaries, and those binaries will use Waffle and piglit-dispatch to choose between GL and GLES based on run-time parameters. Assuming that is the plan, I'm not sure it makes sense to have parse_glspec.py produce different results depending on build parameters. But I could be missing something because I haven't had a chance to look at your entire patch series yet. I don't think Chad and I have ever made an explicit statement on the Piglit list of what our long term plans are with Waffle and piglit-dispatch. I'm getting together with him to write up a summary of our intentions this morning. We'll send that out to the mailing list and then we can have a lively debate :) In the meantime I'll keep reviewing your patches. Paul > > Signed-off-by: Pauli Nieminen <[email protected]> > --- > glapi/parse_glspec.py | 23 +++++++++++++++-------- > 1 files changed, 15 insertions(+), 8 deletions(-) > > diff --git a/glapi/parse_glspec.py b/glapi/parse_glspec.py > index ac624eb..3a1c848 100644 > --- a/glapi/parse_glspec.py > +++ b/glapi/parse_glspec.py > @@ -459,11 +459,18 @@ class Api(object): > > if __name__ == '__main__': > api = Api() > - with open(sys.argv[1]) as f: > - api.read_gl_tm(f) > - with open(sys.argv[2]) as f: > - api.read_gl_spec(f) > - with open(sys.argv[3]) as f: > - api.read_enumext_spec(f) > - with open(sys.argv[4], 'w') as f: > - f.write(api.to_json()) > + for name in sys.argv: > + if name.endswith('.py'): > + continue > + elif name.endswith('gl.tm'): > + with open(name) as f: > + api.read_gl_tm(f) > + elif name.endswith('gl.spec'): > + with open(name) as f: > + api.read_gl_spec(f) > + elif name.endswith('enumext.spec'): > + with open(name) as f: > + api.read_enumext_spec(f) > + elif name.endswith('.json'): > + with open(name, 'w') as f: > + f.write(api.to_json()) > -- > 1.7.5.4 > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit >
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
