On Mon, Aug 27, 2012 at 12:26 PM, Matt Turner <matts...@gmail.com> wrote: > On Sun, Aug 26, 2012 at 12:55 PM, Paul Berry <stereotype...@gmail.com> wrote: >> Minor nit-pick: Our usual convention is to make "pass" a bool, and to write >> this as "pass = piglit_probe_pixel_rgba(...) && pass", just so that it's >> clear that there aren't any bitwise shenanigans going on. Note that it >> would probably make sense to also change the return type of DoTest(), and >> the type of "pass" in piglit_display(), to bool as well. I won't be a >> stickler about it though. > > As it turns out, we've got a good mixture of 'pass = ... && pass', > 'pass = pass && ...", and as I learned today 'pass &= ...'. 445, 351, > and 281 instances respectively. Ugh.
I think this depends on the nature of what's being tested. In some cases a failure may be severe enough that it doesn't make sense to continue testing subsequent cases. Other times we want to keep going. That said, there's probably lots of places where we're doing the wrong thing. -Brian _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
