----- Original Message ----- > On 01/28/2013 04:24 AM, Jose Fonseca wrote: > > Reviewed-by: Jose Fonseca<jfons...@vmware.com> > > > > I assume that PIGLIT_GL_VISUAL_RGBA came from GLUT_RGBA, but given > > that it is a misleading alias for PIGLIT_GL_VISUAL_RGB and there > > is no need to be bug compatible with glut, I believe that in a > > follow on change we should eliminate PIGLIT_GL_VISUAL_RGBA alias, > > so that test writers can immediately notice that they need to add > > PIGLIT_GL_VISUAL_ALPHA when they want it. > > Or, define PIGLIT_GL_VISUAL_RGBA = PIGLIT_GL_VISUAL_RGB | > PIGLIT_GL_VISUAL_ALPHA.
True, but that may mislead those who expect glut semantics or are porting glut tests to piglit. IMHO, the advantage of not defining PIGLIT_GL_VISUAL_RGBA is that it forces test writers to make a conscious decision on whether the need or not alpha. > I imagine Chad might have some plans to address this... Yeah, I'm fine with whatever you or Chad prefer. Jose _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit