On 26 February 2013 02:18, Chris Forbes <chr...@ijw.co.nz> wrote: > This series adds an initial set of tests for the ARB_texture_multisample > extension. I will follow this with more tests to explore some edge cases. > > Changes from V2: > - Leftover window size junk removed > - Misc small tidyups > > -- Chris >
Chris and I have been having some discussion about this over IRC. Just to keep the list updated: - Patches introducing new files (2/8, 3/8, 4/8, 5/8, 8/8) need to have copyright notices added to them. I recommended that Chris just copy and pasting one of the Intel copyright notices (e.g. the one in tests/spec/ext_transform_feedback/structs.c) and replace "Intel Corporation" with his name. - When I reviewed an older version of this series on 1/7, I mentioned some other tests I would like to see added (see http://lists.freedesktop.org/archives/piglit/2013-January/004497.html). I'd still like to see those tests, but I don't think that we need to hold up this patch series (or landing the Mesa implementation) to wait for them. - I don't feel qualified to review patch 7/8 (arb_texture_multisample: add new targets to texelFetch) so I've asked Ken if he can help. - The tests introduced by patch 7/8 currently fail on both Chris's and my nVidia machines. We haven't figured out why. It's possible that it's an nVidia bug, but I think we need to get to the bottom of it before we can have confidence that the test is correct. > > _______________________________________________ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit >
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
