On Wed, Feb 27, 2013 at 11:24 AM, Jordan Justen <jordan.l.jus...@intel.com> wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > ...interface-blocks-member-qualifier-mismatch.vert | 22 > ++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 > tests/spec/glsl-1.50/compiler/interface-blocks-member-qualifier-mismatch.vert > > diff --git > a/tests/spec/glsl-1.50/compiler/interface-blocks-member-qualifier-mismatch.vert > > b/tests/spec/glsl-1.50/compiler/interface-blocks-member-qualifier-mismatch.vert > new file mode 100644 > index 0000000..fead1d8 > --- /dev/null > +++ > b/tests/spec/glsl-1.50/compiler/interface-blocks-member-qualifier-mismatch.vert > @@ -0,0 +1,22 @@ > +// [config] > +// expect_result: fail > +// glsl_version: 1.50 > +// check_link: true > +// [end config] > +// > +// Tests that member qualifier matches the interface block type. > +// > +// GLSLangSpec.1.50.11, 4.3.7 Interface Blocks: > +// "Input variables, output variables, and uniform variables can only > +// be in in blocks, out blocks, and uniform blocks, respectively." > + > +#version 150 > + > +out block { > + uniform vec4 a; // illegal: uniform qualifier within out block > +} inst; > + > +void main() > +{ > +} > + > -- > 1.7.10.4 > > _______________________________________________ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit
I've a small comment on patch 3. Other than that this series is: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit