On 30 September 2013 15:38, Nicholas Mack <nichm...@gmail.com> wrote:

> v2: Add comment
>

I sent a comment on patch 1.  Patches 2-4 are:

Reviewed-by: Paul Berry <stereotype...@gmail.com>


>
> Reviewed-by: Paul Berry <stereotype...@gmail.com>
> ---
>  .../compiler/layout-max-verts-limited.geom         | 23
> ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644
> tests/spec/glsl-1.50/compiler/layout-max-verts-limited.geom
>
> diff --git a/tests/spec/glsl-1.50/compiler/layout-max-verts-limited.geom
> b/tests/spec/glsl-1.50/compiler/layout-max-verts-limited.geom
> new file mode 100644
> index 0000000..9b763a7
> --- /dev/null
> +++ b/tests/spec/glsl-1.50/compiler/layout-max-verts-limited.geom
> @@ -0,0 +1,23 @@
> +// [config]
> +// expect_result: fail
> +// glsl_version: 1.50
> +// check_link: true
> +// [end config]
> +//
> +// Section 4.3.8 (Output Layout Qualifiers) of the GLSL 1.50 spec says:
> +// "It is an error for the maximum number of vertices to be greater than
> +//  gl_MaxGeometryOutputVertices."
> +//
> +// Unfortunately, we can't easlily try to set max_vertices to
> +// gl_MaxGeometryOutputVertices+1, since "max_vertices=" must be
> +// followed by an integer-constant (not a constant expression), so as
> +// a stop gap, we just verify that setting max_vertices = INT_MAX
> +// leads to an error.
> +
> +#version 150
> +
> +layout(max_vertices = 2147483647) out;
> +
> +void main()
> +{
> +}
> --
> 1.8.3.1
>
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to