On Friday, November 15, 2013 04:26:07 PM Damien Lespiau wrote: > On Fri, Nov 15, 2013 at 08:11:07AM -0800, Dylan Baker wrote: > > > + if amount == 'None': > > > + return 'None' > > > > the python idiom is 'if not amount: return None' > > These are strings, not the built-in.
Doh, that's what I get for reviewing patches first thing in the morning :) > > > on a more practicle note, why roll all of this instead of just using > > datetime.timedelta? > > Because it was giving me much more control on how I wanted to display > the time, as you can see. Yes, I guess what I'm really asking is since you've now dropped all times greater than hours is that format worth the extra code? IMHO HH:MM:SS:MS* is just as good as xMin, ySec, zMS, etc; when you consider that datetime.timedelta is provided by python, thus zero maintanence burden.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
