On 07/09/2014 03:10 PM, Matthew McClure wrote:
I reproduced Brian's issue with the NVIDIA drivers. Below is a list of the 
configurations I ran:

GeForce GTX 650
* Ubuntu NVIDIA 304.88 - Allocation of Variable[GL_MAX_VARYING_FLOATS] 
succeeded, VBO usage succeeds.
* Ubuntu NVIDIA 331.89 - Allocation of Variable[GL_MAX_VARYING_FLOATS] fails 
with the following message:

      0(2) : error C5041: cannot locate suitable resource to bind variable 
"Variable". Possibly large array.

GeForce GT 740M
* Windows 8.1 NVIDIA 332.88 - Allocation of Variable[GL_MAX_VARYING_FLOATS] 
succeeded, VBO usage fails.

Due to the issues above, I clamped the return value of GL_MAX_VARYING_FLOATS to 32 and only used immediate 
mode rendering with one attribute. A developer can disable varying floats clamping by specifying the command 
line argument "-dontClampMaxVaryings". A developer can also re-enable different draw paths using 
command line arguments "-drawArraysVBO" or "-drawElementsVBO".

Below is an updated patch to address the issues, as they are not a blocking 
issue for the test to be useful.


OK, the test passes now with my nvidia driver, softpipe, llvmpipe and svga.

A couple more comments on the code.

1. Some of the static, initialized arrays could be const-qualified. Not a big deal though.

2. The standard indentation practice is to use 8-space tabs.

-Brian

_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to