On 04/09/14 23:18, Brian Paul wrote: > On 09/04/2014 03:07 PM, Emil Velikov wrote: >> On 04/09/14 21:56, Brian Paul wrote: >>> On 09/04/2014 02:25 PM, Emil Velikov wrote: >>>> Hi Brian, >>>> >>>> Wouldn't it be better if we add a couple of wrapper functions: >>>> piglit_get_time >>>> and piglit_sleep ? This way we'll be able to keep the tests clean and >>>> OS-agnostic and avoid the trivial duplication introduced with the second >>>> patch :) >>> >>> I want to do that too. But the two "get time" functions in the two test >>> aren't identical (one returns float, the other int64, for example) and I >>> don't >>> have time right now to unify things. >>> >> I fear that's the most common case. Only if Meng-Lin Wu considered this when >> writing the patches originally :'( > > His summer internship is over so I doubt he'll be revisiting it. > Boo... bad student :P
> >> >>> I'd like to commit these as-is for the time being. >>> >> Apart from my hopeful thinking the patches look correct. I wrote almost the >> the same thing for waffle. > > Is that an R-b? > Perhaps should have been more explicit - yes feel free to slap Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> -Emil > -Brian > > _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit