While we're at it, should I update r500.py and r300.py to use the new Piglit blendFunc test that I wrote? I'm not sure how to do that because r300.py and r500.py are setting the GLEAN_BLEND_*_TOLERANCE variables, and I haven't seen similar functionality in Piglit yet. Maybe something involving piglit_set_tolerance_for_bits(), but I don't know how to change this in a python file.
Laura On Tue, Oct 21, 2014 at 10:04 AM, Laura Ekstrand <la...@jlekstrand.net> wrote: > Ok, I just sent a patch to update sanity.py. I'm not really experienced > in Python, so let me know if you have any problems with that patch. It ran > on my machine. > > Laura > > On Mon, Oct 20, 2014 at 8:48 PM, Michel Dänzer <mic...@daenzer.net> wrote: > >> On 21.10.2014 07:49, Laura Ekstrand wrote: >> >>> Thanks for the catch. I took a look at sanity.py, and though I don't >>> know much Python yet, it looks like there are only two tests in there. >>> The Glean basic test will get deleted soon because my ultimate goal is >>> to get rid of Glean altogether. Since readPixSanity is the only other >>> test, do we really need sanity.py anymore? >>> >> >> sanity.py has been useful for bringing up a new driver (or new hardware >> with an existing driver): As long as sanity.py doesn't pass, one doesn't >> need to bother running any of the complete profiles, as the results may not >> be reliable. I'm not sure that the glean basic test needs to be replaced >> with anything for that purpose, but it might be nice to keep sanity.py even >> just for the test you added in patch 1. >> >> >> >> -- >> Earthling Michel Dänzer | http://www.amd.com >> Libre software enthusiast | Mesa and X developer >> > >
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
