On 03/10/14 00:59, Dylan Baker wrote:
This adds additional data to the junit output, specifically it adds the
command used to run a test to the junit output if the test fails.
_______________________________________________
Piglit mailing list
[email protected]
https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=EnAhp9FGvJPMS0ru0EUCoOvDXURwGua3YSQnULfr08k%3D%0A&s=c27e55a2b191dcb8fd11efac69cc761c7aef6833c6295992056f7538673233d9
Patch 1-2 looks good.
Concerning patch 3, I don't feel strongly either way. On one hand, most
of the cases I want to know the command line is indeed when the test
fails. On the other hand, it might be better to have the command line
handy anyway, just in case (e.g, if you want to run a test that is
passing that's related to the one failing).
Either way, this is
Reviewed-by: Jose Fonseca <[email protected]>
Jose
PS: Junit is quite restrictive. I really wished that Jenkins had a less
quirky format, and didn't make so much assumptions about . One of the
things I hate the most is how the test tree gets all screwed up, instead
of being grouped hierarchically.
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
