On 12/12/14 19:33, Jan Vesely wrote:
> Fixes Target links to itself cmake warnings
>
> Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu>
> ---
>
Hmm those seems exist since day 1, yet the intent seems to be missing.
Currently the library tries to link against itself, which is why cmake
is printing out the warnings.
Thanks for clearing this up :)
Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com>
> compile tested. no missing symbols or libraries reported for
> libpiglitutils_glesX.so
>
> tests/util/CMakeLists.gles1.txt | 1 -
> tests/util/CMakeLists.gles2.txt | 1 -
> tests/util/CMakeLists.gles3.txt | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tests/util/CMakeLists.gles1.txt b/tests/util/CMakeLists.gles1.txt
> index 4342cf2..cd9e90d 100644
> --- a/tests/util/CMakeLists.gles1.txt
> +++ b/tests/util/CMakeLists.gles1.txt
> @@ -4,7 +4,6 @@ include_directories(
>
> link_libraries(
> ${UTIL_GL_LIBS}
> - piglitutil_${piglit_target_api}
> )
>
> piglit_add_library(piglitutil_${piglit_target_api}
> diff --git a/tests/util/CMakeLists.gles2.txt b/tests/util/CMakeLists.gles2.txt
> index 4342cf2..cd9e90d 100644
> --- a/tests/util/CMakeLists.gles2.txt
> +++ b/tests/util/CMakeLists.gles2.txt
> @@ -4,7 +4,6 @@ include_directories(
>
> link_libraries(
> ${UTIL_GL_LIBS}
> - piglitutil_${piglit_target_api}
> )
>
> piglit_add_library(piglitutil_${piglit_target_api}
> diff --git a/tests/util/CMakeLists.gles3.txt b/tests/util/CMakeLists.gles3.txt
> index fec284a..a23c0c7 100644
> --- a/tests/util/CMakeLists.gles3.txt
> +++ b/tests/util/CMakeLists.gles3.txt
> @@ -4,7 +4,6 @@ include_directories(
>
> link_libraries(
> ${UTIL_GL_LIBS}
> - piglitutil_${piglit_target_api}
> )
>
> piglit_add_library(piglitutil_${piglit_target_api}
>
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
