OK, I'm abandoning this patch in favor of this one: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume
Mike > -----Original Message----- > From: Dylan Baker [mailto:baker.dyla...@gmail.com] > Sent: Tuesday, May 19, 2015 3:05 PM > To: Mason, Michael W > Cc: Daniel Vetter; piglit@lists.freedesktop.org > Subject: Re: [Piglit] [PATCH] framework/run.py: allow additional excluded > tests on resume > > On Tue, May 19, 2015 at 04:45:59PM +0000, Mason, Michael W wrote: > > How about something like this instead of my original patch? I think we > > should preserve the fact that some tests didn't complete. I'll submit > > this in a separate email if you all agree. > > > > --- a/framework/programs/run.py > > +++ b/framework/programs/run.py > > @@ -313,6 +313,9 @@ def resume(input_): > > type=argparse.FileType("r"), > > help="Optionally specify a piglit config file to > > use. " > > "Default is piglit.conf") > > + parser.add_argument("-n", "--no-retry", dest='no_retry', > > Drop dest down to a new line like the others please. > > > + action='store_true', > > + help="Do not retry incomplete tests") > > args = parser.parse_args(input_) > > _disable_windows_exception_messages() > > > > @@ -342,7 +345,7 @@ def resume(input_): > > # Don't re-run tests that have already completed, incomplete status > > tests > > # have obviously not completed. > > for name, result in results.tests.iteritems(): > > - if result['result'] != 'incomplete': > > + if result['result'] != 'incomplete' or args.no_retry: > > It really doesn't matter but, should we check args.no_retry first? Since > python is lazy I think it will be optimal in most cases. > > > opts.exclude_tests.add(name) > > > This looks reasonable to me. I left a couple of nits above. > > Dylan _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit