On 22/09/15 07:35, Tapani Pälli wrote: > > > On 09/21/2015 04:35 PM, Samuel Iglesias Gonsálvez wrote: >> >> >> On 17/09/15 08:53, Tapani Pälli wrote: >>> >>> On 09/16/2015 11:31 AM, Samuel Iglesias Gonsalvez wrote: >>>> Hello, >>>> >>>> Following my idea described here [0], I modified shader_runner to >>>> accept >>>> other program interfaces. >>>> >>>> The format of the command is: >>>> >>>> active program_interface GL_INTERFACE_TYPE_ENUM var_name >>>> GL_PROPS_ENUM integer >>>> >>>> or, if we include the GL type enum: >>>> >>>> active program_interface GL_INTERFACE_TYPE_ENUM var_name >>>> GL_PROPS_ENUM GL_TYPE_ENUM >>>> >>>> Some examples: >>>> >>>> active program_interface GL_UNIFORM i1 GL_MATRIX_STRIDE 0 >>>> active program_interface GL_UNIFORM i1 GL_IS_ROW_MAJOR 0 >>>> active program_interface GL_PROGRAM_OUTPUT piglit_fragcolor GL_TYPE >>>> GL_FLOAT_VEC4 >>>> active program_interface GL_PROGRAM_INPUT piglit_vertex GL_TYPE >>>> GL_FLOAT_VEC4 >>> >>> From user/reader perspective it is not obvious what 'active >>> program_interface' does. I think it should have something like >>> 'validate' or 'query' in it so that reader knows what is going on. These >>> sounds more like setters now than queries? >> >> OK, What about the following? >> >> active program_interface_query .... ?? >> >> Also, why 'active', you can't >>> query inactive ones? >>> >> >> As it is, you can't. The code is searching an active resource by the >> provided name and when it founds it, the query is done and validated >> with the expected value. >> >> Looking at the spec [0], it defines the queries only for active >> resources. Knowing that, we can even remove the word "active" from the >> aforementioned format as we cannot query inactive ones. >> >> What do you think? > > Yes, "program_interface_query" sounds good to me! >
Taking into account Ian's opinion, I will use: verify program_interface_query .... I will wait until tomorrow before send the new version of the patches, just in case someone wants to add something else. Thanks! :-) Sam >> Sam >> >> [0] https://www.opengl.org/registry/specs/ARB/program_interface_query.txt >> >>> Otherwise, I think it is fine addition if it helps in writing more >>> tests. >>> >>> >>>> What do you think? >>>> >>>> Thanks, >>>> >>>> Sam >>>> >>>> [0] >>>> http://lists.freedesktop.org/archives/piglit/2015-September/017080.html >>>> >>>> Samuel Iglesias Gonsalvez (2): >>>> shader_runner: make active_uniforms's all_types variable be global >>>> shader_runner: Add ARB_program_interface_query support >>>> >>>> tests/shaders/shader_runner.c | 322 >>>> ++++++++++++++++++++++++++++++++---------- >>>> 1 file changed, 244 insertions(+), 78 deletions(-) >>>> >>> >>> >>> // Tapani >>> > _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit