Re: [Piglit] [PATCH 1/2] cmake: use the EGL_CFLAGS_OTHER

[Dylan Baker]

Quoting Ben Widawsky (2016-02-11 17:55:36)
> On Thu, Feb 11, 2016 at 05:43:54PM -0800, Dylan Baker wrote:
> > Quoting Mircea Gherzan (2016-02-11 15:22:48)
> > > Without them, the build will fail on a system without the X headers with
> > > a recent Mesa from the master branch. The EGL_CFLAGS_OTHER define the
> > > MESA_EGL_NO_X11_HEADERS macro that guards the #includes of the X
> > > headers.
> > > 
> > > Signed-off-by: Mircea Gherzan <mircea.gher...@intel.com>
> > > ---
> > >  CMakeLists.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > > index b822934..6a201b8 100644
> > > --- a/CMakeLists.txt
> > > +++ b/CMakeLists.txt
> > > @@ -402,6 +402,7 @@ endif()
> > >  if(EGL_FOUND)
> > >         add_definitions(-DPIGLIT_HAS_EGL)
> > >         include_directories(${EGL_INCLUDE_DIRS})
> > > +       add_definitions (${EGL_CFLAGS_OTHER})
> > >  endif()
> > >  
> > >  if(PIGLIT_BUILD_GLES1_TESTS AND NOT EGL_FOUND)
> > > -- 
> > > 2.5.0
> > > 
> > > _______________________________________________
> > > Piglit mailing list
> > > Piglit@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/piglit
> > 
> > I'm definitely not an authority here, but why does an EGL extension test
> > rely on X?
> 
> He explained it in the commit message... MESA_EGL_NO_X11_HEADERS
> 
> -- 
> Ben Widawsky, Intel Open Source Technology Center

I guess I should more than just glance at the commit message. sigh.

signature.asc
Description: signature

_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit