Quoting Gabriel Feceoru (2016-03-02 05:49:21)
> Deepcopy seems to be very slow and, for specific profiles (igt), causes 
> errors.
> Replacing it with update() method fixes the above problems.
> 
> Signed-off-by: Gabriel Feceoru <[email protected]>
> ---
>  framework/summary/feature.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/framework/summary/feature.py b/framework/summary/feature.py
> index fe2ea23..1ed8e64 100644
> --- a/framework/summary/feature.py
> +++ b/framework/summary/feature.py
> @@ -68,7 +68,8 @@ class FeatResults(object):  # pylint: 
> disable=too-few-public-methods
>              options.OPTIONS.exclude_filter = exclude_filter
>              options.OPTIONS.include_filter = include_filter
>  
> -            profiles[feature] = copy.deepcopy(profile_orig)
> +            profiles[feature] = profile.TestProfile()
> +            profiles[feature].update(profile_orig)
>  
>              # An empty list will raise PiglitFatalError exception
>              # But for reporting we need to handle this situation
> -- 
> 1.9.1
> 
> _______________________________________________
> Piglit mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/piglit

This is the only use of the copy module it looks like, with 'import
copy' removed:
Reviewed-by: Dylan Baker <[email protected]>

Attachment: signature.asc
Description: signature

_______________________________________________
Piglit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to