> No, you can't use int and long here, python 3 doesn't have a long type > at all, and it's int will grow until it uses all of your memory if you > ask it to, while python2 has an int and long that are equivalent to int > and long in C for your architecture. You'll need to use the numpy types > exclusively. As-is this doesn't work with python 3.x it raises a > NameError, so that at least needs to be fixed. > > Also, some of the helper functions in here seem either useless, wrong, > or at least need to have their documentation updated. Many of of them > use floats, which will cause your numpy.integer types to get converted > to their numpy.float equivalent, which you probably don't want, unless > the code casts back, this code is pretty complicated. > > There's also a heck of a lot of this code that is duplicated or nearly > duplicated between builtin_function.py, builtin_function_fp64.py and > this, although I don't have a good solution and I don't really want to > to de-duplicate all of that code myself, so I guess you can just ignore > this comment, consider it me complaining to no one in particular.
You made me feel guilty, so I added support to the main generator script, it seems to work fine. patch on the list. Dave, _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
