Re: [Piglit] [PATCH] shader_runner: report PIGLIT_FAIL if linking unexpectedly fails

[Dylan Baker]

Quoting Brian Paul (2016-10-18 16:28:53)
> We were previously reporting 'pass' if linking failed.
> ---
>  tests/shaders/shader_runner.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index b0bde2c..94865b7 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -3529,6 +3529,7 @@ piglit_display(void)
>  
>         if (!link_ok && !link_error_expected) {
>                 program_must_be_in_use();
> +               full_result = PIGLIT_FAIL;
>         }
>  
>         piglit_present_results();
> -- 
> 1.9.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

And, after looking some more, there's a lot of cases where we need to handle
this.

Dylan

signature.asc
Description: signature

_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit