On Thu, Nov 9, 2017 at 11:55 PM, Brian Paul <bri...@vmware.com> wrote: > On 11/09/2017 03:49 PM, Marek Olšák wrote: >> >> From: Marek Olšák <marek.ol...@amd.com> >> >> --- >> tests/util/piglit-framework-gl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/util/piglit-framework-gl.c >> b/tests/util/piglit-framework-gl.c >> index 29e0e3a..22aadc5 100644 >> --- a/tests/util/piglit-framework-gl.c >> +++ b/tests/util/piglit-framework-gl.c >> @@ -179,20 +179,22 @@ process_args(int *argc, char *argv[], unsigned >> *force_samples, >> } >> } else if (!strcmp(argv[j], "-compat")) { >> if (config->supports_gl_es_version) { >> fprintf(stderr, >> "-compat isn't allowed with ES >> tests!\n"); >> piglit_report_result(PIGLIT_FAIL); >> } >> config->supports_gl_compat_version = 10; >> config->supports_gl_core_version = 0; >> puts("The compatibility profile forced."); >> + delete_arg(argv, *argc, j--); >> + *argc -= 1; >> } >> } >> } >> >> void >> piglit_gl_process_args(int *argc, char *argv[], >> struct piglit_gl_test_config *config) >> { >> unsigned force_samples = 0; >> >> > > Reviewed-by: Brian Paul <bri...@vmware.com> > > IMO, the delete_arg() function should take care of decrementing argc. Want > to do that too?
Not planning to. I don't remember what the other delete_arg call sites expect. Marek _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit