Fabian Bieler <fabianbie...@fastmail.fm> writes: > I think you'll have to call glFinish (or some fence functions) after > altering a buffer and before switching the context to ensure the changes > are visible in the new context.
Thanks for digging up the relevant docs. I tried both Finish (before the context switches) and FenceSync/WaitSync (around them), but neither actually seemed to change the behaviour on radeonsi. I would say a fence is probably the way to go for this test. > I'd appreciate a comment at the top of the file describing the test. > E.g.: what you wrote above. > > I also have some bike-shedding comments if you're into that sort of > thing 😉: > > The "program" variable could be made local. > check_error could be replaced by piglit_check_gl_error(GL_NO_ERROR). > All functions except main could me made static. > Shader creation could be simplified with piglit_build_simple_program. I'll do a cleanup pass before posting an updated patch. Thanks _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit