On 25.01.2018 10:47, Tapani Pälli wrote:


On 25.01.2018 10:27, Tapani Pälli wrote:


On 25.01.2018 07:27, Jason Ekstrand wrote:
On Wed, Jan 24, 2018 at 6:53 AM, Tapani Pälli <tapani.pa...@intel.com <mailto:tapani.pa...@intel.com>> wrote:

    This fixes test for me after Mesa commit 1f79d986af which will
    make device expose entrypoints only for enabled extensions.

    Signed-off-by: Tapani Pälli <tapani.pa...@intel.com
    <mailto:tapani.pa...@intel.com>>
    ---
      src/tests/func/sync/semaphore-fd.c | 6 ++++++
      1 file changed, 6 insertions(+)

    diff --git a/src/tests/func/sync/semaphore-fd.c
    b/src/tests/func/sync/semaphore-fd.c
    index 69e56c2..a977a05 100644
    --- a/src/tests/func/sync/semaphore-fd.c
    +++ b/src/tests/func/sync/semaphore-fd.c
    @@ -45,9 +45,15 @@ struct buffer_layout {
      static void
      init_context(struct test_context *ctx, float priority)
      {
    +   const char *extension_names[] = {
    +      "VK_KHR_external_semaphore_fd",


To be technically correct, we should enable all three external memory extensions and all three external fence extensions.  With that,

Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net <mailto:ja...@jlekstrand.net>>

OK I'll add them all, thanks Jason!

Sanity checking .. these are the device extensions required:

       "VK_KHR_external_memory",
       "VK_KHR_external_memory_fd",
       "VK_KHR_external_semaphore",
       "VK_KHR_external_semaphore_fd",

forgot these:

      "VK_KHR_external_fence",
      "VK_KHR_external_fence_fd",


Instance extensions will be enabled by Crucible itself.



    +   };
    +
          VkResult result = vkCreateDevice(t_physical_dev,
              &(VkDeviceCreateInfo) {
                  .sType = VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO,
    +            .enabledExtensionCount = 1,
    +            .ppEnabledExtensionNames = extension_names,
                  .queueCreateInfoCount = 1,
                  .pQueueCreateInfos = &(VkDeviceQueueCreateInfo) {
                      .sType = VK_STRUCTURE_TYPE_DEVICE_QUEUE_CREATE_INFO,
    --
    2.13.6


_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to