On 05/02/2018 10:47 AM, Eric Anholt wrote: > Ian Romanick <i...@freedesktop.org> writes: > >> From: Ian Romanick <ian.d.roman...@intel.com> >> >> There were two bugs here. First, GL_EXT_blend_color and >> GL_EXT_blend_func_separate were only tested if the version is 1.4. This >> is unnecessary because those extensions are part of OpenGL 1.4. Second, >> GL_EXT_blend_minmax was typoed GL_EXT_blend_min_max. > > Looks like GL_EXT_blend_color at least is only in 1.4 if the imaging > subset is supported, which it looks like we don't do in Mesa. So I
We definitely do not support the imaging subset. My understanding is
that GL_EXT_blend_color was part of the imaging subset in 1.2 and 1.3,
but it was pulled into core in 1.4. I got that from appendix G.3
(Changes to the Imaging Subset), which says:
The subset of blending features described by BlendEquation,
BlendColor, and the BlendFunc modes CONSTANT_COLOR,
ONE_MINUS_CONSTANT_COLOR, CONSTANT_ALPHA, and
ONE_MINUS_CONSTANT_ALPHA are now supported. These feature were
available only in the optional imaging subset in versions 1.2 and
1.3 of the GL.
Mesa's compute_version also requires EXT_blend_color for 1.4.
> think we should disentangle these two changes, and r-b from me on the
> typo fix.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
