On 05/09/18 18:44, Michel Dänzer wrote: > On 2018-09-05 6:29 p.m., Alejandro Piñeiro wrote: >> On 04/09/18 17:24, Michel Dänzer wrote: >>> From: Michel Dänzer <michel.daen...@amd.com> >>> >>> Without this, validate_current_gl_context never returns true if >>> spirv_replaces_glsl == true, resulting in repeatedly calling >>> recreate_gl_context indefinitely after the first subtest. >> Hi, could you provide some extra details? From "indefinitely" I'm >> understanding that shader_runs hangs. > Right (and after some time crashes on my development machine). > > >> How I can reproduce this bug? > Either something like > > ./piglit run --process-isolation false gpu > > or just manually running multiple SPIR-V tests in a single shader_runner > invocation, e.g. > > .../piglit/bin/shader_runner > .../piglit/tests/spec/arb_gl_spirv/execution/vs-ps-simple.shader_test > .../piglit/tests/spec/arb_gl_spirv/execution/vs-ps-specializations.shader_test > -auto -report-subtests > > Thanks for the explanation. I was able to test it, and look a little on it. The patch lgtm:
Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
