Thank you for the comments. The variable names are not always logic... And I don't like the foreach. :) It's really strange. I know it's a wide used keyword... Your set_line advice is very good, I will replace with it my code.
> From: [email protected] > Subject: RE: sqlite bug on Windows? > To: [email protected] > Date: Sun, 22 Aug 2010 13:20:02 +0000 > > Some random comments on the code that has nothing to do with the bug: > > The code is very readable, except for the parts where I'm not sure if > you are making up nonsense names for the variables or not. ;-) > > You could probably replace all your for-loops with foreach: > > for (i = 0; i < sizeof(szamlak); i++) > combo->append_text(szamlak[i]); > > => > > foreach (szamlak; int i; string ch) > combo->append_text(ch); > > It might look strange as a straight C-programmer at first, but it > avoids off-by-one errors in the long run. > > Also, the set_line function could be replaced by this: > > string set_line (sting ch) > { > return ch * 80 + "\n"; > }
