Wes -- We really appreciate all this work and it is certainly very useful. We'll be reviewing and integrating as much of your work from the pull request as possible in the next day or two.
Sorry I missed you today but hopefully we can continue this dialogue on this list and/or on IRC going forward. Again, we really appreciate these contributions! Thanks, Patrick On Mar 14, 2011, at 4:22 PM, Wes Winham wrote: > Hi All, > > Sadly, I only had today for sprinting at pycon and it looks like the > sprint schedule didn't work out very well for the pinax core guys. > After flailing around a bit, I found the fresh-start branch and > started doing some work towards that. > > Basically, my goal was to make as many tests pass as possible and I > have no idea if any of this is useful given the in-between stage of > development. I'm also not sure the best way to submit this stuff back > in a useful way. > > Here's what I did: > * The version of python-twitter in the requirements file doesn't exist > in pypi: > https://github.com/winhamwr/pinax/commit/94214e35459a0c90dc3c6a538f6b3131b1885d32 > * The test runner picks up an Idios test file that's just hanging > around and is broken (but not used by Idios itself): > https://github.com/eldarion/idios/pull/4 > * django-tagging-ext had some tests that wouldn't work when run as > part of pinax, depending on what else you had installed. I generalized > them to work with test models: > https://github.com/pydanny/django-tagging-ext/pull/2 > * There were several missing settings in tests/runner.py that needed > values to stop tests from bonking. I also pulled in the account app > and some related fixes: https://github.com/pinax/pinax/pull/17 > > Feedback on any of this as far as what I can do to get it where it > needs to be useful would be appreciated. > > Thanks > -wes > > -- > You received this message because you are subscribed to the Google Groups > "Pinax Core Development" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/pinax-core-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Pinax Core Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pinax-core-dev?hl=en.
