Hi,

  This issue is now fixed in trunk, thanks a lot.

     Edward

----------
commit 0e1bbf0423600d3fdf73d7f6529e395095087d37
Author: edwardrv <[EMAIL PROTECTED]>
Date:   Mon Nov 10 12:33:01 2008 +0000

    Fix PiTiVi to not use python-2.6 restricted keywords.
    
    Signed-off-by: Edward Hervey <[EMAIL PROTECTED]>
    
    git-svn-id: svn+ssh://svn.gnome.org/svn/pitivi/[EMAIL PROTECTED]
d3729300-e425-0410-8a4c-d956edccc248

diff --git a/pitivi/objectfactory.py b/pitivi/objectfactory.py
index 63d9889..95590d0 100644
--- a/pitivi/objectfactory.py
+++ b/pitivi/objectfactory.py
@@ -462,18 +462,18 @@ class FileSourceFactory(SourceFactory):
         self.settings = ExportSettings()
         if self.video_info_stream:
             # Fill video properties
-            vs = self.video_info_stream
-            self.settings.videowidth = vs.width
-            self.settings.videoheight = vs.height
-            self.settings.videorate = vs.framerate
-            self.settings.videopar = vs.par
+            videostream = self.video_info_stream
+            self.settings.videowidth = videostream.width
+            self.settings.videoheight = videostream.height
+            self.settings.videorate = videostream.framerate
+            self.settings.videopar = videostream.par
 
         if self.audio_info_stream:
             # Fill audio properties
-            as = self.audio_info_stream
-            self.settings.audiochannels = as.channels
-            self.settings.audiorate = as.rate
-            self.settings.audiodepth = as.depth
+            audiostream = self.audio_info_stream
+            self.settings.audiochannels = audiostream.channels
+            self.settings.audiorate = audiostream.rate
+            self.settings.audiodepth = audiostream.depth
 
         return self.settings
 



On Sun, 2008-11-09 at 21:07 +0530, Abhishek Dasgupta wrote:
> Hi,
> 
> I am the package maintainer of pitivi in Arch [1], and
> there's an error when trying to execute pitivi because
> of the declaration of an "as" variable in line 440 of
> pitivi/objectfactory.py:
> 
> Traceback (most recent call last):
> File "/usr/bin/pitivi", line 113, in <module>
> _run_pitivi()
> File "/usr/bin/pitivi", line 102, in _run_pitivi
> import pitivi.pitivi as pitivi
> File "/usr/lib/pitivi/python/pitivi/pitivi.py", line 31, in <module>
> import device
> File "/usr/lib/pitivi/python/pitivi/device.py", line 29, in <module>
> from objectfactory import ObjectFactory, SourceFactory
> File "/usr/lib/pitivi/python/pitivi/objectfactory.py", line 440
> as = self.audio_info_stream
> ^
> SyntaxError: invalid syntax
> 
> I changed the variable name "as" to "audiostream" and it worked. I've
> given the patch below:
> 
> --- pitivi/objectfactory.py 2008-11-09 00:19:03.000000000 +0530
> +++ pitivi/objectfactory.py 2008-11-09 00:27:15.000000000 +0530
> @@ -437,10 +437,10 @@
> 
> if self.audio_info_stream:
> # Fill audio properties
> - as = self.audio_info_stream
> - self.settings.audiochannels = as.channels
> - self.settings.audiorate = as.rate
> - self.settings.audiodepth = as.depth
> + audiostream = self.audio_info_stream
> + self.settings.audiochannels = audiostream.channels
> + self.settings.audiorate = audiostream.rate
> + self.settings.audiodepth = audiostream.depth
> 
> return self.settings
> 
> [1]: http://aur.archlinux.org/packages.php?ID=5461
> 
> I'm not subscribed to the list, so please Cc in any replies.
> 
-- 
Edward Hervey <[EMAIL PROTECTED]>


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Pitivi-pitivi mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi

Reply via email to