Hi,

  Yes, we haven't got round to fixing up all the autotools/tests for the
refactored core (current master).

  Those fixes are now committed.

     Edward,

P.S. We normally handle bug reports and patches through bugzilla
(http://bugzilla.gnome.org/ product:PiTiVi).

On Sat, 2009-02-07 at 01:59 -0500, Chris Ball wrote:
> Hi,
> 
> I just tried out pitivi GIT HEAD for the first time (am so impressed!),
> and make install failed because of missing files.  On investigation, at
> least the following changes were made without updating any Makefile.am:
> 
>  * timelineobjects.py -> trackobjects.py
>  * objectfactory.py -> pitivi/factories/{base,file}.py
>  * pitivi.py -> application.py
>  * add test_factories_{base,file}.py
>  * add elements/arraysink.py
>  * add pitivi/timeline/track.py
>  
> Thanks!
> ---
>  configure.ac                 |    1 +
>  pitivi/Makefile.am           |    4 ++--
>  pitivi/elements/Makefile.am  |    1 +
>  pitivi/factories/Makefile.am |   11 +++++++++++
>  pitivi/timeline/Makefile.am  |    3 ++-
>  pitivi/ui/Makefile.am        |    2 +-
>  tests/Makefile.am            |    4 +++-
>  7 files changed, 21 insertions(+), 5 deletions(-)
>  create mode 100644 pitivi/factories/Makefile.am
> 
> diff --git a/configure.ac b/configure.ac
> index c6566ab..fcf926d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -77,6 +77,7 @@ pitivi/Makefile
>  pitivi/configure.py
>  pitivi/ui/Makefile
>  pitivi/elements/Makefile
> +pitivi/factories/Makefile
>  pitivi/pixmaps/Makefile
>  pitivi/timeline/Makefile
>  pitivi.spec
> diff --git a/pitivi/Makefile.am b/pitivi/Makefile.am
> index 49483c8..cb5e46a 100644
> --- a/pitivi/Makefile.am
> +++ b/pitivi/Makefile.am
> @@ -1,6 +1,7 @@
>  SUBDIRS = \
>       ui              \
>       elements        \
> +     factories       \
>       pixmaps         \
>       timeline
>  
> @@ -9,6 +10,7 @@ pitividir = $(libdir)/pitivi/python/pitivi
>  pitivi_PYTHON = \
>       __init__.py     \
>       action.py       \
> +     application.py  \
>       bin.py          \
>       check.py        \
>       configure.py    \
> @@ -16,9 +18,7 @@ pitivi_PYTHON = \
>       discoverer.py   \
>       effects.py      \
>       instance.py     \
> -     objectfactory.py \
>       pipeline.py     \
> -     pitivi.py       \
>       pitivigstutils.py \
>       playground.py   \
>       plugincore.py   \
> diff --git a/pitivi/elements/Makefile.am b/pitivi/elements/Makefile.am
> index 162ae2b..2b25c02 100644
> --- a/pitivi/elements/Makefile.am
> +++ b/pitivi/elements/Makefile.am
> @@ -2,6 +2,7 @@ elementsdir = $(libdir)/pitivi/python/pitivi/elements
>  
>  elements_PYTHON = \
>       __init__.py \
> +     arraysink.py \
>       imagefreeze.py \
>       singledecodebin.py \
>       smartscale.py   \
> diff --git a/pitivi/factories/Makefile.am b/pitivi/factories/Makefile.am
> new file mode 100644
> index 0000000..e0e0bc6
> --- /dev/null
> +++ b/pitivi/factories/Makefile.am
> @@ -0,0 +1,11 @@
> +factoriesdir = $(libdir)/pitivi/python/pitivi/factories
> +
> +factories_PYTHON = \
> +     __init__.py \
> +     base.py \
> +     file.py \
> +     test.py \
> +     timeline.py
> +
> +clean-local:
> +     rm -rf *.pyc *.pyo
> diff --git a/pitivi/timeline/Makefile.am b/pitivi/timeline/Makefile.am
> index 6f23f8a..b5eacc0 100644
> --- a/pitivi/timeline/Makefile.am
> +++ b/pitivi/timeline/Makefile.am
> @@ -6,7 +6,8 @@ timeline_PYTHON = \
>       effects.py      \
>       objects.py      \
>       source.py       \
> +     track.py        \
>       timeline.py
>  
>  clean-local:
> -     rm -rf *.pyc *.pyo
> \ No newline at end of file
> +     rm -rf *.pyc *.pyo
> diff --git a/pitivi/ui/Makefile.am b/pitivi/ui/Makefile.am
> index 64cbc31..e717cdd 100644
> --- a/pitivi/ui/Makefile.am
> +++ b/pitivi/ui/Makefile.am
> @@ -23,9 +23,9 @@ ui_PYTHON =                 \
>       screencast_managerdialog.py \
>       sourcelist.py           \
>       timelinecanvas.py       \
> -     timelineobject.py       \
>       timeline.py             \
>       track.py                \
> +     trackobject.py          \
>       transitionlist.py       \
>       view.py                 \
>       viewer.py               \
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index fbf8e2c..e51fecd 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -2,6 +2,8 @@ tests = \
>       testHList.py                    \
>       test_basic.py                   \
>       test_binary_search.py           \
> +     test_factories_base.py          \
> +     test_factories_file.py          \
>       test_file_load_save.py          \
>       test_timeline_composition.py    \
>       test_timeline_objects.py        \
> @@ -22,4 +24,4 @@ check-local:
>       @PYTHONPATH=$(top_srcdir):$(PYTHONPATH) $(PYTHON) $(srcdir)/runtests.py
>  
>  %.check: %
> -     @PYTHONPATH=$(top_srcdir):$(PYTHONPATH) $(PYTHON) $(srcdir)/runtests.py 
> $*
> \ No newline at end of file
> +     @PYTHONPATH=$(top_srcdir):$(PYTHONPATH) $(PYTHON) $(srcdir)/runtests.py 
> $*
> -- 
> 1.6.1.2
> 
> 
> -- 
> Chris Ball   <[email protected]>
> 
> ------------------------------------------------------------------------------
> Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
> software. With Adobe AIR, Ajax developers can use existing skills and code to
> build responsive, highly engaging applications that combine the power of local
> resources and data with the reach of the web. Download the Adobe AIR SDK and
> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
> _______________________________________________
> Pitivi-pitivi mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Pitivi-pitivi mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi

Reply via email to