>This is my first attempt at adding validation functionality to TextInput.
Thanks! Looking forward to reviewing it. >Comments >(0) Do I need to do some paperwork for the Apache Foundation in order to >contribute? Yes, you'll need to provide an Individual Contributor License Agreement (ICLA): http://www.apache.org/licenses/icla.txt >(1) Should the naming convention be "DoubleTextValidator" or >"TextValidatorDouble"? "DoubleTextValidator" would be more consistent with Pivot naming conventions. >(2) I dropped > (a) the commit-or-revert behaviour on RETURN and ESCAPE > and (b) storing a value on the Validator. >TextValidation seems sufficiently fundamental that it's worth leaving it >as simple as possible, and it's easy enough to implement >commit-or-revert behaviour with a wrapper class. Agreed. >(3) Do I need to implement some kind of interaction or utility methods >for Form? That's a good question. I thought about that a little bit when you first mentioned the validation framework. I suggest we leave them decoupled for now and see how it goes. >(4) At the moment I'm changing the background colour to indicate >invalidity. >Perhaps it might be better to use an icon-overlay in the lower right corner? This is really up to the skin (which I assume is where you are doing this). If you want to use an overlay icon, you can attach a TagDecorator to the TextInput when the skin is installed and set its tag property as appropriate to show/hide the icon. G
