>If I understand Noel correctly, he's saying that since the objects are >immutable, we may be forced to instantiate new objects where we were >previously modifying the properties of existing objects.
That makes sense. I don't think we are re-using instances of these classes in too many places, so this is probably a minor issue at best. >IMHO, the performance improvement (or degradation) is likely to be so >minor as to not matter - the major advantage is the reduction in >developer error and ambiguity. Agreed - though the reduction in heap allocations may be noticeable in 1.6+ JVMs. I'm leaning closer to advocating this change. Why don't we prototype it and see what the impact will be. Also, while we're in these files, we can address PIVOT-70.
