Yep - good catch.  I've submitted the fix.

-T

On Thu, Apr 30, 2009 at 3:32 AM, Noel Grandin <[email protected]> wrote:
> In TablePane at line 234: see comment inline.
>
> public Component update(int index, Component component) {
>            Component previousComponent = cells.get(index);
>
>            if (component != null
>                && tablePane != null) {
>                // Add the component to the table pane
>                tablePane.add(component);
>
>                // Attach the attributes
>                component.setAttributes(new TablePaneAttributes());
>            }
>
>            cells.update(index, component);
>
>            if (previousComponent != null
>                && tablePane != null) {
>                // Detach the attributes
>  *               component.setAttributes(null);
>>>>>should the preceding line not be
> "previousComponent.setAttributes(null)"?
> *            }
>
>            if (tablePane != null
>                && component != previousComponent) {
>                // Notify table pane listeners
>                tablePane.tablePaneListeners.cellUpdated(this, index,
>                    previousComponent);
>            }
>
>            if (previousComponent != null
>                && tablePane != null) {
>                // Remove the component from the table pane
>                tablePane.remove(component);
>            }
>
>            return previousComponent;
>        }
>

Reply via email to