Thanks Sandro - I'll take a look at the file momentarily. >Then, in the writeObject(), i have not put (in a finally block) the >code that closes the BufferedOutputStream (you said me last day that >there shouldn't be there flush/close of streams in Serializers), is is >right also here ?
Correct. If you close your wrapper stream, it will also close the stream passed into the method, which we don't want. >I've just see that this Serializer doesn't have its test class, so if >needed tomorrow i could create a simple test case for it (and maybe as >a JUnit 4 Test case), what do you think ? Yes, we should definitely have a test case for this. It looks fine, but I'd rather not include it in 1.2 until we've at least done some basic tests. >For the JIRA issue on this file, tell me if i have to close, or if you >want to do it after commit. I'll close it - thanks. >On the Coding standard, what do you think on export your Eclipse >settings and post the file in Subversion (in trunk root, or in tools, >or in an eclipse-specific folder, or other ...) ? >So others could simply import it, and if/when needed reformat sources. This is a good idea. We actually have a TODO to write up an official coding standards doc. Just haven't had time to do it yet. Greg
