>I've found many things like this (approx 6 in charts, and 18 / 20 in wtk): >CalendarButton.java:168 Comparison of String parameter using == or !=
This is a false positive in Find Bugs. We want the code to work this way. We don't want to do a full string scan to check for equality - in most cases, reference equality is sufficient. >What do you think on an utility class (like StringUtils) to put an >utility static method to do these tests (with checks for null, etc), >and maybe under pivot.util, under core ? We have generally avoided creating such utility classes. From our own experience, they don't generally offer much value and tend to clutter the code. >Another interesting thing noted is this: >pivot/wtk/ApplicationContext.java:1201 >pivot.wtk.ApplicationContext.resourceCache is or uses a map or set of >URLs, which can be a performance hog I'd prefer to leave this as-is for now, though feel free to enter a JIRA ticket to investigate it in the future. >Until the deadline of tomorrow i could help to fix some of them, tell me. Nope - we'll leave them as-is for now. Thanks. G
