Int division result cast to double or float

These are OK. In general, we're dividing by 2 to center something, so rounding doesn't really help.

Call to unsupported method
Description: All targets of this method invocation throw an
UnsupportedOperationException.
Component.java:85 Call to unsupported method
org.apache.pivot.beans.BeanDictionary.remove(String)

Good catch. That was a copy/paste error. Fixed.

Class doesn't override equals in the superclass
ArrayList.java:365 org.apache.pivot.wtk.TreeView$BranchHandler doesn't
override org.apache.pivot.collections.ArrayList.equals(Object)

Todd can comment on this one.

Comparator doesn't implement Serializable
=> sorry, maybe some of these have already be discussed, i don't
remember well ...

Yeah - we already covered these. We can ignore them.

Method invokes inefficient Number constructor
=> 8 times ... ok, it's a test class, but i can patch ...
ParentResourcesTest.java:66 Method
org.apache.pivot.util.test.ParentResourcesTest.testInteger() invokes
inefficient new Integer(int) constructor; use Integer.valueOf(int)
instead

Chris, was this intentional, or would valueOf() be OK?

Reply via email to