Scott,
This looks great! Only a few comments, most of them coding-style nitpicks.
* We should probably throw if the column is fixed-width and outside the
limits (both in setWidth() and in setWidthLimits()). This check obviously
wouldn't apply to relative and default width columns.
* [style nit] Instead of the fireEvent flag, we've been going with putting
the whole block in a single if, like so:
if (minimumWidth != previousMinimumWidth
|| maximumWidth != previousMaximumWidth) {
this.minimumWidth = minimumWidth;
this.maximumWidth = maximumWidth;
if (tableView != null) {
tableView.tableViewColumnListeners.columnWidthLimitsChanged(this,
previousMinimumWidth, previousMaximumWidth);
}
}
* [style nit] We've tried to avoid the use of the 'this' keyword unless
necessary, so in setMinimumWidth() and setMaximumWidth(), no need to use it.
We'll hold off on submitting this until you get the JIRA issue resolved just
so we do things by the book, but thanks for the submission!
Cheers,
-T
On Sun, Oct 4, 2009 at 10:30 PM, Scott Lanham <[email protected]> wrote:
> Hi Guys,
>
> I have not disappeared, just didn't touch a line of code for two weeks
> while
> on holiday :-)
>
> I couldn't sign up to JIRA as it gave me a big long error message when I
> tried
> to do so. I will keep on trying but if you could take a look at the patch
> in
> the mean time it would be great.
>
> Cheers,
>
> Scott.
>
