-1 on url_utilities.jsp. You can do this very easily (and more
efficiently) using the properties of the request, as I mentioned
last week.
I'd be happy to do as you say, but it DOESN'T WORK HERE, I've tried
yesterday (see one of my previous mails).
Sorry, I had missed that message - I assume you are referring to this:
http://mail-archives.apache.org/mod_mbox/incubator-pivot-dev/200910.mbox/%[email protected]%3e
- I'm not sure common_properties.jsp contains enough to justify
separating it out into its own file. Additionally, the name of the
file is misleading, since it implies that all JSPs in the www
directory should include it, which is not the case (it only applies
to JNLP files). At a minimum, the name of this file should be
changed to common_properties.jnlp.
I know I have created a solution more than needed, but my trouble is
to give/show a solution that is ready to be used also in other (real)
applications.
I understand. However, JNLP is well documented (it is not a Pivot-
specific feature), so you don't need to demonstrate every possible use
case. You just need to focus on the basics.
Ok, but attention: other jnlp files (like pivot-runtime*) are real and
valid jnlp files, while this if only a jsp fragment to not replicate
code in all jnlp ... at the moment I've done jnlp files only for the
"Kitchen Sink", but I have to do also for other Demos. What do you
think on common_properties_for_jnlp.jsp ?
That makes sense. I would suggest common_jnlp.jsp. I would also
suggest moving the code from url_utilities.jsp to this file.
- I would rename kitchen_sink-signed.jnlp to
kitchen_sink.signed.jnlp, since this is more consistent with our
JAR file naming conventions.
I try to avoid using multiple extensions on files, because for example
on Windows this gives confusion, many times the last extension is not
shown (is used for the showing the file type), and the other(s) goes
in the file name, for example in File Managers.
But Ok, for better consistency, also for pivot-runtime-signed.jnlp .
Ah, I'm thinking to add also a pivot-runtime-all.jnlp (and maybe also
the signed variant), including also the pivot-charts jar. What do you
think ?
Again, I think this is too much. Any reasonable developer should be
able to extrapolate from your existing examples how this could be done.
And last, in current pivot-runtime*.jnlp is missing the pivot-web jar,
it's not used in the "Kitchen Sink", but other use it, and it's a very
little jar so i think it's Ok to add it also here.
I agree that this is OK.
Some additional comments on the code itself:
- The formatting in url_utilities.jsp is not consistent with Pivot
coding standards:
- Do not vertically align variable declarations
- Do not insert a line break before an opening curly brace
- Always wrap if blocks in curly braces
- No leading indent necessary (same for
common_properties_for_jnlp.jsp)
- There are comments in some of the files that appear to contain debug
code. Unless you are actively developing this code, these should be
removed.
G
