I'll take a look. Thanks.
On Friday, October 23, 2009, at 03:59AM, "Sandro Martini"
<[email protected]> wrote:
>Hi to all,
>I've just enabled some Compiler Warnings in latest Eclipse 3.5, and
>for example now I've got some warning on "Redundant null check", like
>this:
>
>Redundant null check: The variable result can only be null at this
>location WTKXSerializer.java /wtk/src/org/apache/pivot/wtkx line
>224 Java Problem
>and many others ... strange that FindBugs doesn't tell nothing on this ...
>
>And others, like:
>Null comparison always yields false: The variable container cannot be
>null at this location WindowSkin.java /wtk/src/org/apache/pivot/wtk/skin
>line
>49 Java Problem
>Redundant assignment: The variable cursor can only be null at this
>location TerraFrameSkin.java
>/wtk/src/org/apache/pivot/wtk/skin/terra line
>754 Java Problem
>Redundant superinterface CalendarListener for the type
>TerraCalendarSkin, already defined by
>CalendarSkin TerraCalendarSkin.java
>/wtk/src/org/apache/pivot/wtk/skin/terra line
>62 Java Problem
>Statement unnecessarily nested within else clause. The corresponding
>then clause does not complete
>normally DigestAuthentication.java /web/src/org/apache/pivot/web
>line
>587 Java Problem
>
>The declared exception SerializationException is not actually thrown
>by the method readNumber(Reader) from type
>JSONSerializer JSONSerializer.java
>/core/src/org/apache/pivot/serialization line
>317 Java Problem
>=> this probably should not be fixed
>
>The import java.awt.Graphics2D is never
>used EventLoggerSkin.java /demos/src/org/apache/pivot/demos/explorer
>line
>19 Java Problem
>
>Unnecessary cast from int to
>double MenuButtons.java /tutorials/src/org/apache/pivot/tutorials/menus
>line
>140 Java Problem
>Unnecessary cast from int to
>float HashMap.java /core/src/org/apache/pivot/collections line
>113 Java Problem
>
>Unnecessary cast from List<capture#2-of ?> to
>List<?> EventLoggerSkin.java
>/demos/src/org/apache/pivot/demos/explorer line
>124 Java Problem
>
>
>Looking better seems good suggestions ... what do you think, fix (some
>of) them ?
>
>Bye
>
>
