FYI, the display isn't theme-able, so it is OK to use a hard-coded color there. Skins defined in org.apache.pivot.skin can also use hard- coded colors. Only skins in org.apache.pivot.skin.terra use theme colors. However, if you see any examples of those that hard-code colors, we should probably fix them.

On Oct 29, 2009, at 10:23 AM, Noel Grandin wrote:


One of the things I don't like in my commit here is that I'm hard- coding
a color (Color.LIGHT_GRAY), which I had to do to match the background
color, which is also hard-coded in DisplaySkin.

Surely these colours should be in the theme file?

Mind you, now that I am searching for them I see that quite a lot of
Skin classes hard-code colors. I guess that's a problem for another day.

-- Noel.

Reply via email to