[ 
https://issues.apache.org/jira/browse/PIVOT-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778324#action_12778324
 ] 

Todd Volkert commented on PIVOT-340:
------------------------------------

TerraFormSkin's calculation needs to better account for the 
'showFirstSectionHeading' style.  As of revision 880724, the following WTKX 
yields an incorrect baseline:

<Window xmlns="org.apache.pivot.wtk" 
xmlns:effects="org.apache.pivot.wtk.effects">
  <content>
    <Form styles="{showFirstSectionHeading:true}">
      <decorators>
        <effects:BaselineDecorator />
      </decorators>
      <sections>
        <Form.Section heading="First Section">
          <TextInput Form.label="Field 1" text="Hello World" />
          <TextInput Form.label="Field 2" text="Hello World" />
        </Form.Section>
        <Form.Section heading="Second Section">
          <TextInput Form.label="Field 3" text="Hello World" />
          <TextInput Form.label="Field 4" text="Hello World" />
        </Form.Section>
      </sections>
    </Form>
  </content>
</Window>


> Update skins to respect height argument in getBaseline()
> --------------------------------------------------------
>
>                 Key: PIVOT-340
>                 URL: https://issues.apache.org/jira/browse/PIVOT-340
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Greg Brown
>             Fix For: 1.4
>
>
> A height argument has been added to getBaseline(). The following skins need 
> to be updated to respect this value:
> - BoxPaneSkin DONE
> - FlowPaneSkin DONE
> - LabelSkin DONE
> - ScrollPaneSkin [NOT DONE]
> - TablePaneSkin [NOT DONE]
> - TerraAccordionSkin DONE
> - TerraCalendarButtonSkin DONE
> - TerraColorChooserButtonSkin DONE
> - TerraFormSkin DONE
> - TerraListButtonSkin DONE
> - TerraListViewSkin DONE
> - TerraMeterSkin DONE
> - TerraMenuButtonSkin DONE
> - TerraTableViewHeaderSkin DONE
> - TerraTableViewSkin DONE
> - TerraTabPaneSkin DONE
> - TerraTextInputSkin DONE
> - TerraTreeViewSkin [NOT DONE]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to