Interesting point. I think you are right - 0 is probably more
appropriate than -1.
G
On Nov 16, 2009, at 6:57 PM, Christopher Brind wrote:
Thanks Greg,
2009/11/16 Greg Brown <[email protected]>
Ah, I see the problem. WTKXSerializer used to expose the line
number as a
property. I had forgotten that it no longer does so.
If we did add this value to SerializationException, we could
potentially
define a value of -1 to mean either "unknown" or "not applicable".
Thoughts?
I put -1 originally, and then I thought that line numbers start at 1
so 0
should be adequate for all other purposes - I don't have a strong
preference
though.
If we go ahead with this change, I think we should also update
JSONSerializer and CSVSerializer. They currently still define a
getLineNumber() method that should probably be removed and replaced
by the
value in the exception.
I have no strong opinion either way, but can make this change if you
think
it's appropriate.
Cheers,
Chris
G
On Nov 16, 2009, at 6:26 PM, Christopher Brind wrote:
I don't see how - any suggestions?
2009/11/16 Greg Brown <[email protected]>
Any objections if I add the following to SerializationException in
order
to
support the Pivot plugin?
Possibly. Not all serializers read text files, so a line number
is not
always meaningful.
Is it not possible to use the line number that already provided
by the
serializer?
