On Fri, 2 Sep 2011 18:06:26 -0400, Søren Sandmann <sandm...@cs.au.dk> wrote: > This patch series change pixman-access.c to generate most accessors > with macros and inline functions instead of writing out the code for > all the functions. This is a fairly significant saving in terms of > lines of code: > > pixman-access.c | 3159 > +++++++++++-------------------------------------------- > pixman-private.h | 43 > pixman-utils.c | 34 > 3 files changed, 724 insertions(+), 2512 deletions(-) > > but the main motivation is that will eventually make it easier to add > floating point fetchers so that we can add a floating point pipeline. > > Comments welcome.
The final patch is a little scary though. Was that motivated by observation of the generated assembly or through performance testing? Anyway it's hard to argue against such removal, when gcc should only get better ;-) Can pixman export a wrapper to its convert_pixel function? There are quite a few open-coded routines for doing the same spread around the X server and its brethren. -Chris -- Chris Wilson, Intel Open Source Technology Centre
_______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
