On Mon, 17 Dec 2012 01:51:26 +0100 sandm...@cs.au.dk (Søren Sandmann) wrote:
> Siarhei Siamashka <siarhei.siamas...@gmail.com> writes: > > > This is not intended to be immediately pushed to pixman git repository. > > At least not until it proves to have some real practical use. Except > > maybe for the 'xor'->'filler' variable rename patch, which clearly > > should not cause any regressions or inconveniences. > > There is a number of things in this series that look like good changes > regardless of moving to C++ or not. Some I noticed: > > The SIZE_MAX change was requested here: > > http://lists.freedesktop.org/archives/pixman/2012-August/002196.html > > and someone recently mailed me privately and pointed out that Solaris 9 > doesn't have it either. > > The xor->filler change should be harmless as you point out, and 'filler' > probably is a better name than 'xor'. > > The uint32->pixman_format_t in pixman-glyph.c looks good. OK, I'll try to split "[PATCH 4/4] Various remaining fixes needed for successful compilation with C++" and re-submit a smaller patch with only the changes that are not C++ specific, but also useful for C. -- Best regards, Siarhei Siamashka _______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman