Hi, The only nitpicky comment I have on this merge request is that in fetch_scanline_r8g8b8_sRGB_float() there are spurious spaces between to_linear and the '['. Other than that,
Reviewed-by: soren.sandm...@gmail.com I'm no longer the maintainer of pixman, and I probably don't have commit access to the repository anymore, so I can't push this myself. Thanks, Søren On Wed, Mar 10, 2021 at 11:33 AM Claude Heiland-Allen <cla...@mathr.co.uk> wrote: > > Hi, > > I think I've implemented it now. Test suite passes, and it seems to > work in my real code (modulo issue #43; next on my todo list is testing > also with merge request !40): > > https://gitlab.freedesktop.org/pixman/pixman/-/merge_requests/44 > > Thanks, > > > Claude > > On 05/03/2021 23:38, Søren Sandmann wrote: > > There isn't really any guide. > > On Fri, Mar 5, 2021 at 11:00 AM Claude Heiland-Allen <cla...@mathr.co.uk> > > wrote: > > > > On 04/03/2021 19:55, Søren Sandmann wrote: > >>> You are right that pixman doesn't have support for sRGB formats > >>> without an alpha channel. It would make sense to add such support (and > >>> it should be straightforward to do so). > >> Is there a guide for this kind of work? > _______________________________________________ > Pixman mailing list > Pixman@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/pixman _______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pixman
