Your message dated Sat, 02 May 2009 19:32:16 +0000
with message-id <[email protected]>
and subject line Bug#518821: fixed in devscripts 2.10.49
has caused the Debian Bug report #518821,
regarding [debsign] pgp method broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
518821: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=518821
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.47

It seems to me that the pgp signature method is broken:
ASCII_SIGNED_FILE is used in the statement, but it has not been
assigned.  The patch also adds an additional newline, similar to the
gpg case.  I haven't got a copy of PGP, so I can't test if it's
necessary, but I guess it doesn't hurt, either.

(I'm using the pgp method with a completely different signing backend
which reads from standard input and writes to standard output.)

--- /usr/bin/debsign    2009-03-04 20:25:31.000000000 +0100
+++ /home/fw/bin/debsign        2009-03-08 05:04:03.000000000 +0100
@@ -170,19 +170,19 @@
 # information when this function is read first.
 signfile () {
     local savestty=$(stty -g 2>/dev/null) || true
+    mksigningdir
+    UNSIGNED_FILE="$signingdir/$(basename "$1")"
+    ASCII_SIGNED_FILE="${UNSIGNED_FILE}.asc"
+    (cat "$1" ; echo "") > "$UNSIGNED_FILE"
+
     if [ $signinterface = gpg ]
     then
-       mksigningdir
-       UNSIGNED_FILE="$signingdir/$(basename "$1")"
-       ASCII_SIGNED_FILE="${UNSIGNED_FILE}.asc"
-
        gpgversion=`gpg --version | head -n 1 | cut -d' ' -f3`
        gpgmajorversion=`echo $gpgversion | cut -d. -f1`
        gpgminorversion=`echo $gpgversion | cut -d. -f2`
 
        if [ $gpgmajorversion -gt 1 -o $gpgminorversion -ge 4 ]
        then
-               (cat "$1" ; echo "") > "$UNSIGNED_FILE"
                $signcommand --local-user "$2" --clearsign \
                    --list-options no-show-policy-urls \
                    --armor --textmode --output "$ASCII_SIGNED_FILE"\
@@ -193,7 +193,6 @@
                  exit $SAVESTAT
                }
        else
-               (cat "$1" ; echo "") > "$UNSIGNED_FILE"
                $signcommand --local-user "$2" --clearsign \
                    --no-show-policy-url \
                    --armor --textmode --output "$ASCII_SIGNED_FILE" \
@@ -205,7 +204,8 @@
                }
        fi
     else
-       $signcommand -u "$2" +clearsig=on -fast < "$1" > "$ASCII_SIGNED_FILE"
+       $signcommand -u "$2" +clearsig=on -fast \
+           < "$UNSIGNED_FILE" > "$ASCII_SIGNED_FILE"
     fi
     stty $savestty 2>/dev/null || true
     echo



--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.49

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:

devscripts_2.10.49.dsc
  to pool/main/d/devscripts/devscripts_2.10.49.dsc
devscripts_2.10.49.tar.gz
  to pool/main/d/devscripts/devscripts_2.10.49.tar.gz
devscripts_2.10.49_amd64.deb
  to pool/main/d/devscripts/devscripts_2.10.49_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam D. Barratt <[email protected]> (supplier of updated devscripts 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 02 May 2009 19:34:55 +0100
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.10.49
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: Adam D. Barratt <[email protected]>
Description: 
 devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 478833 518821 520903 523523 523982 524198 524393 525823 526047
Changes: 
 devscripts (2.10.49) unstable; urgency=low
 .
   * debchange:
     + Use == for numeric comparison, not eq.
     + Mention in the help output and manpage that a dummy changelog entry
       may be supplied in conjunction with --release in order to avoid
       spawning an editor.
     + Add a configuration variable and command line option to allow the
       recent change to --release's "auto-save" behaviour to be disabled.
       For consistency with other debchange options, the default is to
       retain the behaviour introduced in 2.10.48 - i.e. that the changelog
       must be explicitly saved after the use of --release. (Closes: #524393)
   * debcommit: If the installed version of dpkg-dev supports retrieving a
     list of appropriate bugs, automatically generate bzr --fixes arguments
     for Launchpad bugs as well as Debian bugs.  Thanks, Colin Watson.
     (Closes: #525823)
   * debsign: Make the PGP signing method work again.  Thanks, Florian Weimer.
     (Closes: #518821)
   * getbuildlog: Add a missing "use lib" to allow the special "last" and
     "last-all" versions to work correctly.  Thanks, Iustin Pop.
     (Closes: #523982)
   * licensecheck: Add detection of the AGPL.  Thanks, Didier Raboud.
     (Closes: #520903)
   * namecheck: Fix the formatting of a number of POD strings, also making
     them easier to translate.  Thanks, Florentin Duneau.  (Closes: #526047)
   * rc-alert:
     + Allow the generated list of bugs to be restricted to those affecting
       packages with particular debtags facets.  Thanks, Jan Hauke Rahm.
      (Closes: #523523)
     + Allow the generated list of bugs to be sorted using popcon results.
       Thanks, Jan Hauke Rahm.  (Closes: #478833)
   * rmadison: Allow a default URL to be specified in the configuration file.
     Thanks, Roland Mas.  (Closes: #524198)
   * uscan: Remove a superfluous and repeated copy of the site name in an FTP
     error message.  Thanks, Vaclav Ovsik.
   * Makefile: Remove cruft relating to French manpages, which has been handled
     by the po4a setup for a while now.
Checksums-Sha1: 
 f8968344ec2742e198eb2d63e87289ea4457db9a 1363 devscripts_2.10.49.dsc
 04438fd1485fcbc2eab874539c851b3a01a729ce 660222 devscripts_2.10.49.tar.gz
 416303a2b2334e33a7884a76d3b0812a25a3a7b1 564514 devscripts_2.10.49_amd64.deb
Checksums-Sha256: 
 1c736132a714c5ffc6bed7d6058beaf15eeb30d3b52f73cf824987c14b128d8a 1363 
devscripts_2.10.49.dsc
 95defb2da2601012f5e93624a023ba2ea10046aade63f2384316f3ece2b8a0b0 660222 
devscripts_2.10.49.tar.gz
 9fc513514776f5f57303987cb02d00a6d03d200b8e9e86fec6cfc0fbb0f94bfe 564514 
devscripts_2.10.49_amd64.deb
Files: 
 8d75e537043202fa8177210814b9d3e7 1363 devel optional devscripts_2.10.49.dsc
 cadfe2da932dba5bdab1cfe00ebc0003 660222 devel optional 
devscripts_2.10.49.tar.gz
 4b8feae39fa311b90068f6e541c433b9 564514 devel optional 
devscripts_2.10.49_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkn8lBUACgkQokcE1TReOoUCfgCbBNubuegOA9SYbcVxEDCkaDli
ETsAoIWaZaAYErK/4fYPFBy8iqJfiy/l
=7QcT
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to