[EMAIL PROTECTED] wrote:
Hi, The following is a webrev for the Package Rename feature:http://cr.opensolaris.org/~johansen/pkg_rename/index.html This change allows us to change the names of packages and still have sane behavior. Once we have this functionality we can get away from names like SUNWlibc and do more sane things like library/libc, or whatever we deem to be appropriate.
I haven't had time to go through all of your changes, but a bit of logic in modules/catalog.py confuses me:
539 552 try:
553 + if entry[0] not in tuple("CV"):
554 + continue
555 +
540 556 cv, pkg, cat_name, cat_version =
entry.split()
541 - if cv not in tuple("CV") or pkg !=
"pkg":
557 + if pkg != "pkg":
542 558 continue
543 559 except ValueError:
544 560 # Handle old two-column catalog
file, mostly in
545 561 # use on server.
562 + if entry[0] not in tuple("CV"):
563 + continue
546 564
Maybe it is my poor understanding of Python, but I don't see how line 562
could be reached if the condition is met in line 553?
Same with lines 599/610. Trev
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
