It seems I flubbed up a bit and typo'd a constant name in four spots
in depot.py for bug 255:
--- a/src/depot.py Thu Feb 21 16:48:59 2008 -0800
+++ b/src/depot.py Thu Feb 21 23:14:42 2008 -0600
@@ -144,7 +144,7 @@ def manifest_0(scfg, request):
else:
request.log_error("Internal failure:\n%s",
traceback.format_exc())
- request.send_response(httplib.INTERNAL_SERVER_RROR)
+ request.send_response(httplib.INTERNAL_SERVER_ERROR)
return
data = file.read()
@@ -244,7 +244,7 @@ def file_0(scfg, request):
else:
request.log_error("Internal failure:\n%s",
traceback.format_exc())
- request.send_response(httplib.INTERNAL_SERVER_RROR)
+ request.send_response(httplib.INTERNAL_SERVER_ERROR)
return
data = file.read()
@@ -274,7 +274,7 @@ def open_0(scfg, request):
elif ret == httplib.BAD_REQUEST:
request.send_response(httplib.BAD_REQUEST)
else:
- request.send_response(httplib.INTERNAL_SERVER_RROR)
+ request.send_response(httplib.INTERNAL_SERVER_ERROR)
def close_0(scfg, request):
@@ -402,7 +402,7 @@ class pkgHandler(BaseHTTPServer.BaseHTTP
# client, in which case this response just
corrupts that
# datastream. I don't know of any way to tell whether
# data has already been sent.
- self.send_response(httplib.INTERNAL_SERVER_RROR)
+ self.send_response(httplib.INTERNAL_SERVER_ERROR)
def do_POST(self):
self.do_GET()
This never revealed itself during the review, hg nits, my own checks,
or "make test" sadly.
So what's the process for fixing bad commits?
I'm obviously sorry it happened and will endeavour to do better, but
what's the way forward?
Cheers,
--
Shawn Walker, Software and Systems Analyst
http://binarycrusader.blogspot.com/
"To err is human -- and to blame it on a computer is even more so." -
Robert Orben
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
