On Fri, Feb 22, 2008 at 5:01 PM, <[EMAIL PROTECTED]> wrote: > Gentlemen, > I have another easy code review. This time, it is for CR 587. This > fixes the traceback that Dan found while writing test cases. I had > forgotten to handle additional exceptions that the FMRI constructor > might raise. > > Webrev is available from: > > http://cr.opensolaris.org/~johansen/webrev-587/index.html
Some of those past 80 column lines were my fault. Since I'll be running pylint from now on (smile) -- that shouldn't happen anymore. Anyway, as to your changes, they look fine to me. Cheers, -- Shawn Walker, Software and Systems Analyst http://binarycrusader.blogspot.com/ "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
