Danek Duvall wrote:
>> http://cr.opensolaris.org/~barts/bug-539/
>
> license.py:
>
> - line 56: I don't see how this is different at all from the previous
> incarnation, except that it's not right for user images.
>
Previous incarnation leaves one w/ prepended '/'.
This causes various oddities, because:
: [EMAIL PROTECTED]; python
Python 2.4.4 (#1, Feb 1 2008, 02:13:35) [C] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.path.join("/one", "/two")
'/two'
>>>
I find this behavior counter-intuitive, to say the least....
I'll add a image function return the correct prefix so user images
will work.
> - line 69: no need for two blank lines here.
>
> - line 74: this could be more robust -- if dirname(path) isn't a
> directory, etc. No, we've not been particularly careful about any
> of these so far.
>
Yes; I swiped this from the file action... and the only place path gets
set is in the preinstall method, so I don't understand how dirname(path)
could be anything but a directory....
> - line 75: spaces around "="
>
Thanks.
Trev wrote:
> Should we check to see if 'path' exists before use and if it does,
perform some rudimentary checks on it?
See above - the path is explicitly forced in the preinstall method.
This code does need more armor plating,
but so do most of the actions.
"I _will_ run pylint, I _will_ run pylint."
- Bart
--
Bart Smaalders Solaris Kernel Performance
[EMAIL PROTECTED] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
